Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modality retrieval from path #656

Merged
merged 9 commits into from
Mar 15, 2024

Conversation

nbeliy
Copy link
Collaborator

@nbeliy nbeliy commented Nov 21, 2023


Modality retrieval is quite simple:

  1. From path get the latest directory as modality candidate
  2. Compare ses (or sub, if no sessions) entity with directory above, if it's matches, then modality candidate is accepted.

If concept is approved, I'll update the tests.

@Remi-Gau
Copy link
Collaborator

sorry it took me this long to reply

Yes that makes sense to me so far: I will let you add / fix tests. As usual, I suspect this will be fairly robust when working with vanilla BIDS but could get funky when not working on validated BIDS dataset but so be it.

@Remi-Gau Remi-Gau marked this pull request as ready for review March 15, 2024 21:17
@Remi-Gau Remi-Gau merged commit cef3db0 into bids-standard:main Mar 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Retrieval of modality by bids.File
2 participants